-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(analytics): improve dapp details tracking and SDK RPC request analytics #1179
Conversation
- Implemented analytics tracking for SDK RPC requests when not sending via network. - Integrated SendAnalytics function to log SDK_RPC_REQUEST events with relevant parameters.
- Removed deprecated SDK version ID and updated channelId declaration to use const. - Enhanced caching logic for channel information, ensuring validation of cached data. - Added logging for cases with empty cached channel info to improve debugging. - Refactored incrementRedisCacheOperation calls for better readability.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1179 +/- ##
==========================================
- Coverage 74.12% 74.03% -0.10%
==========================================
Files 181 181
Lines 4298 4305 +7
Branches 1053 1056 +3
==========================================
+ Hits 3186 3187 +1
- Misses 1112 1118 +6 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
This pull request includes several changes to the Code Cleanup and Type Consistency:
Analytics Tracking:
Code Refactoring:
|
Description
This PR addresses two critical analytics-related issues that were causing missing dapp details and incomplete event tracking:
Issue 1: Missing SDK RPC Request Analytics
When using the deeplink protocol, the SDK would directly open the deeplink without going through the network path, causing analytics events to be missed. This PR ensures analytics events are properly tracked regardless of the communication method used.
Changes:
SendAnalytics
function to logSDK_RPC_REQUEST
events with method and source informationIssue 2: Invalid Cached Dapp Details
The system was not properly validating cached dapp information in Redis, leading to events being sent without proper dapp details.
Changes:
Technical Implementation:
Breaking Changes
None. This PR maintains backward compatibility while improving analytics tracking reliability.
Testing Instructions
Test SDK RPC Request Analytics:
Test Dapp Details Caching:
Related Issues