Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for personal_ecRecover #707

Merged
merged 3 commits into from
Feb 27, 2024
Merged

feat: add support for personal_ecRecover #707

merged 3 commits into from
Feb 27, 2024

Conversation

abretonc7s
Copy link
Collaborator

Explanation

Redirect to wallet on personal_ecRecover

References

(https://app.zenhub.com/workspaces/metamask-sdk-6359297a36f20292c13feca0/issues/gh/metamask/metamask-sdk/706)

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@abretonc7s abretonc7s requested a review from a team as a code owner February 26, 2024 12:09
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.54%. Comparing base (94fb4af) to head (1ee5e9c).

❗ Current head 1ee5e9c differs from pull request most recent head 2ad4a19. Consider uploading reports for the commit 2ad4a19 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #707   +/-   ##
=======================================
  Coverage   79.54%   79.54%           
=======================================
  Files         170      170           
  Lines        3550     3550           
  Branches     1025     1025           
=======================================
  Hits         2824     2824           
  Misses        726      726           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andreahaku andreahaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abretonc7s abretonc7s merged commit 5e8b101 into main Feb 27, 2024
9 checks passed
@abretonc7s abretonc7s deleted the feat/ec-recover branch February 27, 2024 14:44
This was referenced Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants