Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: devnext change to flex UI layout #719

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Conversation

ecp4224
Copy link
Collaborator

@ecp4224 ecp4224 commented Mar 1, 2024

Explanation

Currently, the devnext UI uses a top-down layout in the demo page and doesn't center items. This PR updates the demo page to add flexboxes to split the connected page vertically and to center the connecting page. These changes make the UI easier to read at a glance

References

Screen.Recording.2024-03-01.at.1.50.10.AM.mov

Changelog

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@ecp4224 ecp4224 requested a review from omridan159 March 1, 2024 02:14
@ecp4224 ecp4224 requested a review from a team as a code owner March 1, 2024 02:14
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.48%. Comparing base (a0af2a3) to head (7563cf0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #719   +/-   ##
=======================================
  Coverage   81.48%   81.48%           
=======================================
  Files         173      173           
  Lines        3446     3446           
  Branches      805      805           
=======================================
  Hits         2808     2808           
  Misses        638      638           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@omridan159 omridan159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omridan159 omridan159 changed the title Feat/devnext/flex UI layout feat: devnext change to flex UI layout Mar 6, 2024
@omridan159 omridan159 merged commit 94ecdc8 into main Mar 6, 2024
33 checks passed
@omridan159 omridan159 deleted the feat/devnext/flex-ui-layout branch March 6, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants