Fix broken latitude/longitude values for TCX

Metalnem · Jan 29, 2017 · 2f3ea6a · 2f3ea6a
1 parent d02dc39
commit 2f3ea6a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/static/tcx/gps.tcx b/static/tcx/gps.tcx
@@ -16,8 +16,8 @@
             <DistanceMeters>20</DistanceMeters>
             <AltitudeMeters>2814.324</AltitudeMeters>
             <Position>
-              <LatitudeDegrees>28.915173</LatitudeDegrees>
-              <LongitudeDegrees>31.87212</LongitudeDegrees>
+              <LatitudeDegrees>28.91528</LatitudeDegrees>
+              <LongitudeDegrees>31.87315</LongitudeDegrees>
             </Position>
           </Trackpoint>
           <Trackpoint>
@@ -28,7 +28,7 @@
             <DistanceMeters>40</DistanceMeters>
             <AltitudeMeters>2816.279</AltitudeMeters>
             <Position>
-              <LatitudeDegrees>28.915173</LatitudeDegrees>
+              <LatitudeDegrees>28.91517</LatitudeDegrees>
               <LongitudeDegrees>31.87212</LongitudeDegrees>
             </Position>
           </Trackpoint>

diff --git a/tcx/tcx.go b/tcx/tcx.go
@@ -76,6 +76,8 @@ func (exp *Exporter) Export(a api.Activity) error {
 	var points []trackPoint
 
 	for _, point := range a.Data {
+		point := point
+
 		tp := trackPoint{
 			Time:     point.Time.Format(time.RFC3339),
 			Distance: point.Distance,
@@ -88,8 +90,7 @@ func (exp *Exporter) Export(a api.Activity) error {
 		}
 
 		if point.HeartRate > 0 {
-			heartRate := point.HeartRate
-			tp.HeartRate = &heartRate
+			tp.HeartRate = &point.HeartRate
 		}
 
 		points = append(points, tp)

diff --git a/tcx/tcx_test.go b/tcx/tcx_test.go
@@ -74,9 +74,9 @@ func TestGPS(t *testing.T) {
 		Distance:  50,
 		Data: []api.DataPoint{
 			{Time: mustParse("2012-10-15T09:32:00Z")},
-			{Time: mustParse("2012-10-15T09:35:00Z"), Longitude: 31.87315, Latitude: 28.915283, Elevation: 2814.324, Distance: 20},
+			{Time: mustParse("2012-10-15T09:35:00Z"), Longitude: 31.87315, Latitude: 28.91528, Elevation: 2814.324, Distance: 20},
 			{Time: mustParse("2012-10-15T09:37:00Z")},
-			{Time: mustParse("2012-10-15T09:40:00Z"), Longitude: 31.87212, Latitude: 28.915172, Elevation: 2816.279, Distance: 40},
+			{Time: mustParse("2012-10-15T09:40:00Z"), Longitude: 31.87212, Latitude: 28.91517, Elevation: 2816.279, Distance: 40},
 		},
 	}