Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quickstart-feature-flag-spring-boot.md #124947

Conversation

mervynmanilall
Copy link
Contributor

Hello,

I have added a section that show how to do the connection with a yaml file. Currently, only the implementation for '.properties' file is given. However, '.yaml' files are becoming popular and the YAML snippet ensures that users can easily reference and implement the instructions without additional research or effort, improving the overall usability of the documentation.

Regards

added a new tab for yaml file when using app configuration in spring-boot
Copy link
Contributor

@mervynmanilall : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 29cf82d:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-app-configuration/quickstart-feature-flag-spring-boot.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Nov 26, 2024

@mrm9084
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Nov 26, 2024
@mervynmanilall
Copy link
Contributor Author

Hello @mrm9084 ,

Any update please?

Regards

@mrm9084
Copy link
Contributor

mrm9084 commented Dec 2, 2024

#sign-off

@Jak-MS
Copy link
Contributor

Jak-MS commented Dec 2, 2024

@mervynmanilall @mrm9084 - because the PR adds tab functionality, we can't merge it via the public repo. The commits will need to be moved to the private repo and checked on staging before we can merge them.

@mrm9084 - can you move the commits? (let us know if you'd like our assistance.)
#hold-off

Copy link
Contributor

You typed hold-off, but the PR wasn't signed off, so nothing was changed.

Copy link
Contributor

Learn Build status updates of commit c942d87:

✅ Validation status: passed

File Status Preview URL Details
articles/azure-app-configuration/quickstart-feature-flag-spring-boot.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@mervynmanilall
Copy link
Contributor Author

Hello @Jak-MS ,

Any update please? Is there any action from my side?

@Jak-MS
Copy link
Contributor

Jak-MS commented Dec 10, 2024

Hello @Jak-MS ,

Any update please? Is there any action from my side?

@mrm9084 - do you want us to move this to the private repo?

@mrm9084
Copy link
Contributor

mrm9084 commented Dec 11, 2024

Hello @Jak-MS ,
Any update please? Is there any action from my side?

@mrm9084 - do you want us to move this to the private repo?

We just updates our docs to have Entra ID and Connection String samples, which lines up with this. I don't we can add tabs here because we use tabs for Entra ID/Connection String. @Jak-MS do you have a suggestion for how to do this?

@Jak-MS
Copy link
Contributor

Jak-MS commented Dec 11, 2024

Hello @Jak-MS ,
Any update please? Is there any action from my side?

@mrm9084 - do you want us to move this to the private repo?

We just updates our docs to have Entra ID and Connection String samples, which lines up with this. I don't we can add tabs here because we use tabs for Entra ID/Connection String. @Jak-MS do you have a suggestion for how to do this?

@mrm9084

In our markdown interpreter, you can have both sets of tabs, since one is in step one and the other is in step two. I don't know if the tab labels makes sense from a content/instructional perspective, but there's not a limitation in having 2 sets of tabs.

@mervynmanilall
Copy link
Contributor Author

Hi @mrm9084 , I hope you're doing well!
I just wanted to kindly follow up on this pull request. Could you please address the feedback and make the necessary updates when you have a chance?
Thanks for your contribution and looking forward to your updates!

@mrm9084
Copy link
Contributor

mrm9084 commented Dec 19, 2024

Hi @mrm9084 , I hope you're doing well! I just wanted to kindly follow up on this pull request. Could you please address the feedback and make the necessary updates when you have a chance? Thanks for your contribution and looking forward to your updates!

Do you have a way to solve the issue in my above comment?

@mervynmanilall
Copy link
Contributor Author

Hello @mrm9084 @Jak-MS,

I have created a fresh PR: #125467
I have structured it the same way as the other sections to maintain consistency.
If this new pr works, I will close this one.
Please check.

Regards

@Jak-MS
Copy link
Contributor

Jak-MS commented Jan 8, 2025

@mervynmanilall @mrm9084 - considering the new PR, I'm closing this one. It can be reopened if need be. @mrm9084 - can you review the other PR? #125467 thanks!

@Jak-MS Jak-MS closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants