-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update quickstart-feature-flag-spring-boot.md #124947
Update quickstart-feature-flag-spring-boot.md #124947
Conversation
added a new tab for yaml file when using app configuration in spring-boot
@mervynmanilall : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit 29cf82d: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@mrm9084 Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
Hello @mrm9084 , Any update please? Regards |
#sign-off |
@mervynmanilall @mrm9084 - because the PR adds tab functionality, we can't merge it via the public repo. The commits will need to be moved to the private repo and checked on staging before we can merge them. @mrm9084 - can you move the commits? (let us know if you'd like our assistance.) |
You typed hold-off, but the PR wasn't signed off, so nothing was changed. |
Learn Build status updates of commit c942d87: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Hello @Jak-MS , Any update please? Is there any action from my side? |
We just updates our docs to have Entra ID and Connection String samples, which lines up with this. I don't we can add tabs here because we use tabs for Entra ID/Connection String. @Jak-MS do you have a suggestion for how to do this? |
In our markdown interpreter, you can have both sets of tabs, since one is in step one and the other is in step two. I don't know if the tab labels makes sense from a content/instructional perspective, but there's not a limitation in having 2 sets of tabs. |
Hi @mrm9084 , I hope you're doing well! |
Do you have a way to solve the issue in my above comment? |
@mervynmanilall @mrm9084 - considering the new PR, I'm closing this one. It can be reopened if need be. @mrm9084 - can you review the other PR? #125467 thanks! |
Hello,
I have added a section that show how to do the connection with a yaml file. Currently, only the implementation for '.properties' file is given. However, '.yaml' files are becoming popular and the YAML snippet ensures that users can easily reference and implement the instructions without additional research or effort, improving the overall usability of the documentation.
Regards