Conversation
NianJiuZst
left a comment
There was a problem hiding this comment.
Reviewed head 3b1a83a. The focused quota-table suite (11/11) and typecheck pass locally, but I found two cases to address:
-
weeklyModel = models[0]suppresses the new header countdown whenever the first model is "not in plan", even if a later model has a valid weekly quota. I reproduced this with an unavailable video model first and an available general model second: the table showed no1w Reset. Please select a model with a usable weekly window before deciding whether to render the header countdown, and add a mixed-model regression test. -
Issue #248 specifies hours only below one day. With
weekly_remains_timeset to 23 hours, the new header renders1w Reset 23h 0m. Please use the requested compact format for the weekly header.
The only reported GitHub check is skipped, so CI has not independently validated this head.
|
Addressed both review points in commit 5f5e466: the weekly header now selects the first usable weekly-quota model (with a mixed unavailable/available regression test), and sub-day weekly countdowns use compact hours (23h, without a trailing 0m). Focused quota-table tests pass 11/11 and typecheck passes locally; the repository check remains skipped by its workflow. |
Summary
Fixes #248.
weekly_start_time,weekly_end_time, andweekly_remains_timefields.Test Plan
bun test test/output/quota-table.test.ts— 11 passedbun run typecheck— passedbun run lint— 0 errors; one pre-existing warning intest/sdk/speech.test.tsbun run build— passedbun test— 563 passed, 12 existing Windows-environment failures involving permissions, symlinks, proxy state, andpowershell.exe; the changed quota suite passesNotes
PR #255 added seconds for sub-minute reset durations and explicitly stated that the weekly header proposed in #248 was not included. This PR implements that remaining UI request without changing API or JSON output.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.