Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Check Technologies to GBFS systems #557

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

Rens660
Copy link
Contributor

@Rens660 Rens660 commented Oct 25, 2023

No description provided.

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@josee-sabourin josee-sabourin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @Rens660! Thank you for this contribution!

@josee-sabourin josee-sabourin merged commit 9cefbe3 into MobilityData:master Oct 25, 2023
1 check passed
@richfab
Copy link
Contributor

richfab commented Nov 20, 2023

Hi @Rens660,
I'm Fabien, Community Developer Advocate at MobilityData.
Feel free to share here if you're planning to implement changes from v3.0-RC2.
Please let me know if you have any questions.
Thank you!

@futuretap
Copy link
Contributor

Hi @Rens660, it looks like each individual city feed returns all vehicles countrywide. E.g. the Delft feed also returns mopeds from Rotterdam, Den Haag, Amsterdam etc.
Can you fix that?

@richfab
Copy link
Contributor

richfab commented Jan 6, 2025

Hi @duvenagep and @Rens660,

I'm following up on @futuretap's comment.

The data issue is that some Check vehicles are duplicated across multiple GBFS feeds. For example, the Delft feed contains vehicles from Rotterdam and vice versa (see visualization).

This does not follow the best practices of the GBFS spec: "The gbfs.json discovery file SHOULD represent a single system or geographic area in which vehicles are operated."

This is a missed opportunity for Check as trip planners might not display your vehicles if they are duplicated across multiple feeds.

Potential solutions:

  • List only vehicles located in the city area in the feed.
  • Aggregate the feeds that constitute a city cluster as defined in your FAQ (see screenshot below).

I am available for any questions.
Thanks in advance 🙏

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants