Repository navigation
fixes to make L10n buildtask work on Linux - #188
Open
LinusCenterstrom wants to merge 1 commit into
Open
LinusCenterstrom wants to merge 1 commit into
LinusCenterstrom wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates the L10n build task for Linux compatibility and newer .NET runtime support.
Changes:
- Invokes the task DLL through
dotnet. - Uses
DOTNET_HOST_PATHwhen available. - Enables major-version runtime roll-forward.
- Bumps the package version to 4.0.8.
| File | Description |
|---|---|
MN.L10n.BuildTasks/MN.L10n.BuildTasks.csproj |
Updates version and runtime roll-forward configuration. |
MN.L10n.BuildTasks/build/MN.L10n.BuildTasks.props |
Enables cross-platform DLL execution through the .NET host. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In short we run the build task with dotnet "MN.L10n.BuildTasks.dll" rather than running the exe directly.
Also added rollForward major to make it work on systems that only have newer versions of the runtime (in this case only net10)