Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(workflows-api): add workflow api and supporting deployment script #108

Merged
merged 13 commits into from
Feb 28, 2024
Merged

feat(workflows-api): add workflow api and supporting deployment script #108

merged 13 commits into from
Feb 28, 2024

Conversation

ividito
Copy link
Contributor

@ividito ividito commented Feb 16, 2024 •
edited
Loading

Summary:

Addresses #105

Adds a workflow API to support running DAGS without needing an AWS account with access to the MWAA UI.

Changes

  • Adds workflow API, including all functionality from the original veda-backend PR
  • This API is deployed using terraform, and in addition to having its image hosted on ECR, it will attach itself to an existing Cloudfront distribution. To a user, it will appear as if it is a core VEDA service, alongside those deployed in veda-backend

PR Checklist

  • Update CHANGELOG
  • Unit tests
  • Ad-hoc testing - Deploy changes and test manually
  • Integration tests

@ividito ividito force-pushed the feature/workflows-api branch from f111994 to 118ae55 Compare February 16, 2024 02:39
@ividito ividito force-pushed the feature/workflows-api branch from 118ae55 to c3ead2f Compare February 16, 2024 02:39
@ividito ividito force-pushed the feature/workflows-api branch from e039dca to 2b1750e Compare February 16, 2024 02:46
@ividito ividito force-pushed the feature/workflows-api branch from 5ed4b12 to 2d8efab Compare February 16, 2024 02:50
@ividito ividito mentioned this pull request Feb 23, 2024
Merged
@ividito ividito marked this pull request as ready for review February 26, 2024 18:27
anayeaye
anayeaye reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@anayeaye anayeaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few questions but I'm excited to start trying this out very soon

workflows_api/runtime/src/validators.py Show resolved Hide resolved
workflows_api/runtime/src/airflow_helpers.py Show resolved Hide resolved
infrastructure/main.tf Show resolved Hide resolved
@ividito ividito merged commit cfe7ef0 into dev Feb 28, 2024
12 checks passed
@ividito ividito deleted the feature/workflows-api branch February 28, 2024 16:56
@slesaad slesaad mentioned this pull request Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anayeaye anayeaye anayeaye approved these changes

@moradology moradology Awaiting requested review from moradology

@slesaad slesaad Awaiting requested review from slesaad

@botanical botanical Awaiting requested review from botanical

@amarouane-ABDELHAK amarouane-ABDELHAK Awaiting requested review from amarouane-ABDELHAK

@smohiudd smohiudd Awaiting requested review from smohiudd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ividito @anayeaye