Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:table): radio selection type #8823

Open
wants to merge 42 commits into
base: master
Choose a base branch
from

Conversation

ParsaArvanehPA
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[✔] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

In Ant design it is possible to have both checkbox and radio as selection type for columns; meanwhile we only support checkbox selection type.

Issue Number: #8029

What is the new behavior?

Now supports radio selection type.

Does this PR introduce a breaking change?

[ ] Yes
[✔] No

Other information

ParsaArvanehPA and others added 30 commits February 1, 2024 22:52
# Conflicts:
#	components/table/doc/index.en-US.md
#	components/table/doc/index.zh-CN.md
Comment on lines +1 to +7
---
order: 2
title:
en-US: Selection
zh-CN: 可选择
---

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the order number 2 was unused.

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.87%. Comparing base (0202a19) to head (ccbadd6).

Files with missing lines Patch % Lines
components/table/src/cell/td-addon.component.ts 60.00% 1 Missing and 1 partial ⚠️
components/table/src/addon/selection.component.ts 0.00% 1 Missing ⚠️
...omponents/table/src/cell/th-selection.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8823      +/-   ##
==========================================
- Coverage   91.89%   91.87%   -0.03%     
==========================================
  Files         546      546              
  Lines       19291    19297       +6     
  Branches     2850     2851       +1     
==========================================
+ Hits        17728    17729       +1     
- Misses       1251     1255       +4     
- Partials      312      313       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ParsaArvanehPA ParsaArvanehPA changed the title Feature/radio selection in table feat(module:table): radio selection type Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants