Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate construction of rtr_client_reset_queries #992

Conversation

sleinen
Copy link
Contributor

@sleinen sleinen commented Jan 6, 2025

This change eliminates duplicate rtr_client_reset_queries in per-client RTR metrics. Not only does the code still compile, it's running on one of our production RPKI servers now. The metrics have reappeared in Prometheus after the initial validation phase and still look good. And best of all, I no longer see messages such as this from our Prometheus scraper:

Jan 06 20:37:00 prom-scraper prometheus[1609784]: ts=2025-01-06T20:37:00.386Z caller=scrape.go:1754 level=warn component="scrape manager" scrape_pool=node-exporter target=http://rpki4.net.switch.ch:9556/metrics msg="Error on ingesting samples with different value but same timestamp" num_dropped=8

Before installing the patched version, such messages appeared in the Prometheus log every 15 seconds (scrape_interval).

Fixed #991

@partim
Copy link
Member

partim commented Jan 7, 2025

Thank you very much for the PR! Looking good!

@partim partim merged commit 245b0fb into NLnetLabs:main Jan 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate rtr_client_reset_queries section in HTTP metrics
2 participants