Remove duplicate construction of rtr_client_reset_queries #992
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change eliminates duplicate
rtr_client_reset_queries
in per-client RTR metrics. Not only does the code still compile, it's running on one of our production RPKI servers now. The metrics have reappeared in Prometheus after the initial validation phase and still look good. And best of all, I no longer see messages such as this from our Prometheus scraper:Before installing the patched version, such messages appeared in the Prometheus log every 15 seconds (
scrape_interval
).Fixed #991