Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JGDAS_ENKF_SFC and JGDAS_ENKF_UPDATE jobs with COMIN/COMOUT instead of COM #3170
base: develop
Are you sure you want to change the base?
Update JGDAS_ENKF_SFC and JGDAS_ENKF_UPDATE jobs with COMIN/COMOUT instead of COM #3170
Changes from 14 commits
adcab3e
5bc8e78
705dab5
6803d1e
c3ae578
311db65
8c7f6c8
6027460
5b49863
5beadef
f79ce30
357a648
952d808
168858d
9d620d0
6248b68
6f4ddfe
815cd11
2b42b9a
10ea8bd
709adca
e83e143
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an output. It's possible COM_ATMOS_ANALYSIS is both an IN and an OUT for this job. Please evaluate what the script is doing carefully to determine what are inputs and what are outputs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second Walter's comment. It appears that
COM_ATMOS_ANALYSIS
is both an IN and an OUT for this job. Please examine and if you agree, please define the variable twice, once as an IN and once as an OUT. Then update the script to use the appropriate IN or OUT version of the variable. Thanks!