Add additional GEFS variables needed for AI/ML applications #3221
+57
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The umax, vmax and wndmax variables have been added to the diag tables. Also maxuw has been recognized as components of a vector variable in exglobal_atmos_products.sh.
aerorahul
reviewed
Jan 10, 2025
ush/forecast_predet.sh
Outdated
Comment on lines
578
to
585
| memnum=$(echo "${ENSMEM}" | cut -c2-3) | ||
| if [[ "${ENSMEM}" == "000" ]]; then | ||
| export e1=1 | ||
| else | ||
| export e1=3 | ||
| fi | ||
| export e2=${memnum} | ||
| export e3=${NMEM_ENS} |
There was a problem hiding this comment.
Should these be wrapped in a GEFS conditional?
Either way, leave a comment here why this is done as it is not obvious.
Suggested change
| memnum=$(echo "${ENSMEM}" | cut -c2-3) | |
| if [[ "${ENSMEM}" == "000" ]]; then | |
| export e1=1 | |
| else | |
| export e1=3 | |
| fi | |
| export e2=${memnum} | |
| export e3=${NMEM_ENS} | |
| if [[ "${ENSMEM}" == "000" ]]; then | |
| export e1=1 | |
| else | |
| export e1=3 | |
| fi | |
| export e2="${ENSMEM:1:2}" | |
| export e3="${NMEM_ENS}" |
aerorahul
reviewed
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR covers a few items that were merged to the
feature/gefs_reforecastbranch and should be brought to thedevelopbranch:With the additional variables, the data size has increased from 7.41GB to 7.96GB for a given member in atmos products.
This PR will be left in draft mode until more testing is completed.
Resolves #3205
Refs #3183
Type of change
Change characteristics
How has this been tested?
Checklist