fix the resolving of genbank and jgi IDs #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcroci2
approved these changes
Nov 25, 2024
Replace webpage parsing with requesting NCBI REST API v2
CunliangGeng
force-pushed
the
fix_resolving_genbank_jgi_ids
branch
from
254690b to
1528ee8
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit test
tests/unit/genomics/test_podp_antismash_downloader.py(e.g. action output) has failed because the code cannot successfully resolve the RefSeq accessions for GenBank ID or JGI ID any more. This caused by the change of NCBI website.This PR fixes the issue by requesting latest NCBI REST API to replace the parsing of webpage.