PowerAnalytics Entity-Metric Redesign #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first commit in a major PowerAnalytics redesign.
Previously, the test simulations only contained one RenewableDispatch component and did not dispatch any thermal generation. Now there is a solar RenewableDispatch component, and nonzero thermal generation for 2/5 generators. The old PowerAnalytics test still work.
Additional changes in this commit: - Generalize compute_all to take Components - Make create_problem_results_dict return SortedDict
Rather than setting `agg_fn`/`reduce_fn` when calling `compute` or `aggregate_time`, metrics now specify how they should be aggregated across Entities and across time.
- Add and test the ability to have `entity_agg_fn` and `time_agg_fn` use column element-wise "aggregation metadata" for things like weighted averages - Add options for how to aggregate the aggregation metadata itself (insufficiently tested) - Add option to specify what the result of `compute` looks like when there are no components (insufficiently tested) - Fix built-in curtailment fraction and integration calculations using weighted_average
I'm bumping up the version number from 0.5.2 to 0.6.0 to reflect the first draft of the Entity-Metric redesign. I'm also adding myself as the first author to reflect the fact that this redesigned version of the package is meant to be the main one in use going forward.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## psy4 #19 +/- ##
==========================================
- Coverage 88.46% 80.17% -8.29%
==========================================
Files 3 8 +5
Lines 312 686 +374
==========================================
+ Hits 276 550 +274
- Misses 36 136 +100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Very roughly a thousand times faster on very large systems. Requires NREL-Sienna/PowerSimulations.jl#1079
…decision_problem_results
…roblem_results Replace get populated decision problem results
Move ComponentSelector from PowerAnalytics to InfrastructureSystems: PA portion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft pull request representing the major PowerAnalytics redesign. Not yet ready for review. More information to follow!