feat(sc): stream PPO actor and critic minibatches - #3963
Closed
tianyi-zhang-02 wants to merge 3 commits into
Closed
tianyi-zhang-02 wants to merge 3 commits into
tianyi-zhang-02 wants to merge 3 commits into
Conversation
tianyi-zhang-02
marked this pull request as ready for review
September 2, 2026 15:11
tianyi-zhang-02
force-pushed
the
codex/sc-ppo-critic-minibatches
branch
2 times, most recently
from
September 12, 2026 17:28
be96caa to
c210993
Compare
Signed-off-by: Tianyi Zhang <123608656+tianyi-zhang-02@users.noreply.github.com>
Signed-off-by: Tianyi Zhang <123608656+tianyi-zhang-02@users.noreply.github.com>
Signed-off-by: Tianyi Zhang <123608656+tianyi-zhang-02@users.noreply.github.com>
tianyi-zhang-02
force-pushed
the
codex/sc-ppo-critic-minibatches
branch
from
September 13, 2026 02:52
c210993 to
1253e02
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Lets Single Controller PPO stream actor and Megatron critic minibatches from native TQ replay instead of materializing one merged training payload.
The critic now has an explicit begin/train-chunk/finish/abort lifecycle. Chunks accumulate gradients and correctly normalized diagnostics, then take one optimizer step at the end of each critic epoch. The controller retains replay rows across critic and actor epochs, cleans up partial failures, skips invalid chunks, and rejects drop budgets that cannot preserve data-parallel batch divisibility.
Relates to #2625.
Validation
Current head
1253e0264a5a7665440fcff6607f63cd450164bc, rebased on upstreammainatd633032b2a8017c69ddfff9183deb42cab6b36f4.megatron.bridge)2a9b108apre-refresh head)The main refresh composes the intervening MOPD, NeMo Gym, refit, token-capture, training-claim, finalizer-metric, and rollout-checkpoint changes with PPO's multi-epoch row retention. The #3925 reconciliation uses the new
sample_clearscheckpoint-barrier mutation category for both PPO and non-PPO cleanup, while retaining the PPO-specific early cleanup on failure.The 2-GPU Megatron split-parity and functional runs have not been rerun at the current head, so current-head GPU confirmation remains pending.
Functional entry point:
Before your PR is ready for review