Deprecate CUB iterators existing in Thrust #3304
Open
+67
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardmgruber
force-pushed
the
depr_cub_iterators
branch
from
3197c5d to
11a30b9
Compare
elstehle
reviewed
Jan 9, 2025
| @@ -231,7 +231,7 @@ struct dispatch_streaming_arg_reduce_t | |||
| cudaStream_t stream) | |||
| { | |||
| // Constant iterator to provide the offset of the current partition for the user-provided input iterator | |||
| using constant_offset_it_t = ConstantInputIterator<GlobalOffsetT>; | |||
| using constant_offset_it_t = THRUST_NS_QUALIFIER::constant_iterator<GlobalOffsetT>; | |||
There was a problem hiding this comment.
Could you please check if the sass remains the same after this change for cub.bench.reduce.arg_extrema.base?
bernhardmgruber
force-pushed
the
depr_cub_iterators
branch
2 times, most recently
from
299ed13 to
41c62b9
Compare
bernhardmgruber
force-pushed
the
depr_cub_iterators
branch
from
41c62b9 to
eeb02ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3261