Repository navigation
fix(ci): print lychee failure URLs in the job log - #3240
mangeshraut712 wants to merge 2 commits into
Conversation
When LYCHEE_REPORT_DIR forces --format json, the console only showed the short permanent/transient summary. Echo the final failure table (source, URL, status) so broken links are visible without opening the report artifact. Fixes NVIDIA#3204.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
|
| Layer / File(s) | Summary |
|---|---|
Render and verify failure details ci/tools/retry_lychee.py, ci/tools/tests/test_retry_lychee.py |
finish renders the report once and prints it when failures are present. The test checks the captured output and retains assertions for no retry and the Markdown report. |
Assessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
Identify which links fail in the CI output [#3204] |
✅ |
Suggested reviewers: rwgk
Priority:
Change: Bug fix · Severity of issue fixed: Low
Merge Risk: 
Minimal · previous review bdfc2
-
The change is mergeable with no identified current-head risk.
Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Summary
When
LYCHEE_REPORT_DIRforces--format json, the job log only printed the short permanent/transient summary (Lychee has permanent or unclassified link failures…). The failing URLs already lived in the markdown report / step summary, but not in the console.Echo the final failure table (source, URL, status, details) after that message so broken links are visible without opening the uploaded report artifact.
Fixes #3204.
Test plan
python3 -m pytest ci/tools/tests/test_retry_lychee.py(90 passed)