Skip to content

fix(ci): print lychee failure URLs in the job log - #3240

Open
mangeshraut712 wants to merge 2 commits into
NVIDIA:mainfrom
mangeshraut712:tip/lychee-verbose-failures
Open

mangeshraut712 wants to merge 2 commits into
NVIDIA:mainfrom
mangeshraut712:tip/lychee-verbose-failures

Conversation

@mangeshraut712

Copy link
Copy Markdown
Contributor

Summary

When LYCHEE_REPORT_DIR forces --format json, the job log only printed the short permanent/transient summary (Lychee has permanent or unclassified link failures…). The failing URLs already lived in the markdown report / step summary, but not in the console.

Echo the final failure table (source, URL, status, details) after that message so broken links are visible without opening the uploaded report artifact.

Fixes #3204.

Test plan

  • python3 -m pytest ci/tools/tests/test_retry_lychee.py (90 passed)
  • Permanent-failure cases assert the escaped URL appears on stdout

When LYCHEE_REPORT_DIR forces --format json, the console only showed the
short permanent/transient summary. Echo the final failure table (source,
URL, status) so broken links are visible without opening the report
artifact. Fixes NVIDIA#3204.
@copy-pr-bot

copy-pr-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-27T09:24:22.959353Z
We couldn’t complete this review. Comment @codex review to try again.
bdfc2cf PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actions github-actions Bot added the CI/CD CI/CD infrastructure label Oct 27, 2026
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration
Commits

Reviewing files that changed from the base of the PR and between bdfc2cf and 2f6bb4c.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 590a8bf and bdfc2cf.

Files selected for processing: 2
  • ci/tools/retry_lychee.py
  • ci/tools/tests/test_retry_lychee.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

  • Improvements
    • When link-check failures occur, CI output now includes the detailed failure table alongside the classification message, making failure details easier to review.
    • The Markdown report continues to include the failure details, with the final report rendered once and reused for the artifact.
    • When there are no failures, CI output retains its existing message or warning.

The finish function now prints detailed link failure information to the CI console and reuses the rendered report in the Markdown artifact. The test checks the console output for the failure classification, table header, and escaped URL.

Changes: Lychee failure reporting

Layer / File(s) Summary
Render and verify failure details
ci/tools/retry_lychee.py, ci/tools/tests/test_retry_lychee.py
finish renders the report once and prints it when failures are present. The test checks the captured output and retains assertions for no retry and the Markdown report.

Assessment against linked issues

Objective Addressed Explanation
Identify which links fail in the CI output [#3204] ✅

Suggested reviewers: rwgk

Priority: Low

Change: Bug fix · Severity of issue fixed: Low

Merge Risk: Minimal · previous review bdfc2

The change is mergeable with no identified current-head risk.

Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lychee should specify which links are failing

1 participant