Skip to content

[no-ci] CI: fix Node probe summary bold formatting and run probe daily - #3265

Merged
juenglin merged 1 commit into
NVIDIA:mainfrom
juenglin:runner-trust-probe-followup
Oct 28, 2026
Merged

juenglin merged 1 commit into
NVIDIA:mainfrom
juenglin:runner-trust-probe-followup

Conversation

@juenglin

Copy link
Copy Markdown
Contributor

Description

Follow-on to #3251.

Two small fixes to the runner trust probe:

  1. Node summary formatting — core.summary.addTable() generates an HTML
    <table>, not markdown. Inside HTML table cells, **PASS**/**FAIL**
    renders as literal text with visible asterisks. Replaced with <strong>
    tags so the Status column renders bold as intended. (The bash and PowerShell
    scripts write raw markdown directly to $GITHUB_STEP_SUMMARY where **
    does render, so they are unchanged.)

  2. Daily schedule — Changed from weekly on Mondays (23 6 * * 1) to daily
    at 06:00 PST / 14:00 UTC (0 14 * * *) for tighter tracking while the
    Windows hosted runner fixes (OS trust store update and runner agent v2.338.1
    rollout) are still in progress.

Checklist

  • New or existing tests cover these changes. (N/A — workflow and JS probe helper only)
  • The documentation is up to date with these changes. (N/A — internal CI workflow only)

runner_trust_probe_node.js: core.summary.addTable() generates an HTML
table, not markdown, so **PASS**/**FAIL** appeared as literal asterisk-
wrapped text in the summary view. Use <strong> tags instead.

runner-trust-probe.yml: change schedule from weekly on Mondays
(cron: "23 6 * * 1") to daily at 06:00 PST (cron: "0 14 * * *")
for tighter remediation tracking while the Windows runner fix rolls out.
@juenglin juenglin added this to the cuda.bindings next milestone Oct 28, 2026
@juenglin juenglin added the CI/CD CI/CD infrastructure label Oct 28, 2026
@copy-pr-bot

copy-pr-bot Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@juenglin juenglin self-assigned this Oct 28, 2026
@juenglin juenglin changed the title CI: fix Node probe summary bold formatting and run probe daily [no-ci] CI: fix Node probe summary bold formatting and run probe daily Oct 28, 2026
@juenglin
juenglin requested a review from jpascucci-nv October 28, 2026 17:16
@juenglin

Copy link
Copy Markdown
Contributor Author

/ok to test bbad2d9

@juenglin
juenglin marked this pull request as ready for review October 28, 2026 17:16
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

📝 Summary

Summary by CodeRabbit

  • Chores
    • The scheduled runner trust check now runs daily at 14:00 UTC instead of weekly.
    • Trust-check status labels use bold formatting in the generated report. These presentation changes do not affect the reported status values or gating behavior.

The runner trust probe schedule now runs daily at 14:00 UTC. Its three status cells use HTML <strong> formatting. Status values and gating behavior remain unchanged.

Changes: Runner trust probe

Layer / File(s) Summary
Probe schedule and status output
.github/workflows/runner-trust-probe.yml, ci/tools/runner_trust_probe_node.js
The workflow schedule changes to daily at 14:00 UTC, with its comment describing 06:00 PST. The three status cells switch from Markdown bold markers to HTML <strong> tags.

Possibly related PRs

Suggested reviewers: andy-jost

Priority: Low

Change: Bug fix

Merge Risk: Low · up to bbad2

The probe schedule is correct, but its comment can mislead operators about the daily run time across daylight saving changes.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


Review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 94625c1 and bbad2d9.

Files selected for processing: 2
  • .github/workflows/runner-trust-probe.yml
  • ci/tools/runner_trust_probe_node.js

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

schedule:
# Weekly on Mondays at 06:23 UTC
- cron: "23 6 * * 1"
# Daily at 06:00 PST (14:00 UTC)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Maintainability & Code Quality · Quick win

suggestion: Use a timezone-neutral schedule comment. 0 14 * * * runs at 14:00 UTC. It is 06:00 PST only during standard time. During daylight saving time, it is 07:00 PDT. Change the comment to Daily at 14:00 UTC.

@juenglin
juenglin merged commit 8079296 into NVIDIA:main Oct 28, 2026
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD CI/CD infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants