-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/query microservices #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-2.1' into feature/queryMicroservicesAccumulo2.1
…-2.1' into feature/queryMicroservicesAccumulo2.1
…yMicroservicesAccumulo2.1
…yMicroservicesAccumulo2.1
…yMicroservicesAccumulo2.1
jwomeara
commented
Apr 19, 2024
api/src/main/java/datawave/security/authorization/ProxiedUserDetails.java
Outdated
Show resolved
Hide resolved
jwomeara
commented
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notable changes in this PR:
- Added direct dependency on accumulo
- Moved the AuthorizationsPredicate logic here so it would be available to both the webservice and query microservices
- Added listEffectiveAuthorizations endpoint (which technically was introduced with spring boot 2.x) and added support for federation of this request to downstream systems
- Replicating some of the functionality found in UserOperationsBean for the query microservices
- AuthorizationsListSupplier was moved to the datawave microservice starter since multiple services now need it
foster33
reviewed
Apr 22, 2024
service/src/main/java/datawave/microservice/authorization/AuthorizationOperationsV1.java
Outdated
Show resolved
Hide resolved
apmoriarty
approved these changes
Apr 22, 2024
alerman
approved these changes
Apr 25, 2024
matthpeterson
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.