Conversation
A top-bar action always renders as a bare icon — the label prop is
a11y-only, and a label-only action falls back to the ellipsis /
more_vert placeholder. show-label makes the label visible: text alone
("Edit"-style), or icon + text when an icon is set. iOS needs
.labelStyle(.titleAndIcon) because toolbars collapse a Label to
icon-only; Android renders a TextButton so the M3 disabled tone and
ripple still apply. Unset keeps today's icon-only rendering.
Member
|
Does this respect custom text colours on Android the same way it does iOS? Looks like |
simonhamp
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's wrong
Top-bar actions are always drawn as a bare icon.
labelis only read by screen readers, and an action with a label but no icon shows a generic "more" icon. Sometimes a word is clearer than an icon ("Add", "Edit").What this does
A new opt-in
show-labelattribute draws the label:Without
show-label, nothing changes. On iOS the toolbar would otherwise shrink a label down to its icon, so it's told to keep both. On Android it's a regular text button, so thedisabledlook and the touch ripple still work.How to reproduce
The first two actions show their label, the third stays icon-only as before.