Implement websocket client API #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejgray
approved these changes
Apr 25, 2024
|
Deployed to hana.neonaialpha.com with neon/neon auth |
This can be tested now with configuration: neon_node:
description: Neon Node
# hana_address: https://hana.neonaiservices.com
hana_address: https://hana.neonaialpha.com
hana_username: neon
hana_password: neon |
Add a helper method to get client permissions by client id Add /node/v1 websocket route
Refactor to keep permissions in jwt tokens
Annotate test coverage for changes
Add test coverage for `get_permissions` and `ClientPermissions`
Refactor user configuration handling to support multiple users and updates from Neon
NeonDaniel
force-pushed
the
FEAT_Websocket
branch
from
3d9adfc to
8bdf324
Compare
NeonDaniel
added a commit
to NeonGeckoCom/neon-nodes
that referenced
this pull request
May 22, 2024
# Description Implements a WS communication-based client Refactor to minimize duplicate code # Issues <!-- If this is related to or closes an issue/other PR, please note them here --> # Other Notes - Goes with NeonGeckoCom/neon-hana#20 --------- Co-authored-by: Daniel McKnight <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a websocket API for a Node client
Adds
ClientPermissionsobject to define per-client permissionsIssues
Closes #6
Other Notes
Example client implementation: NeonGeckoCom/neon-nodes#14