Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extra metrics utils import #483

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Fix extra metrics utils import #483

merged 1 commit into from
Nov 10, 2023

Conversation

NeonDaniel
Copy link
Member

@NeonDaniel NeonDaniel commented Nov 10, 2023 •
edited
Loading

Description

Depending on init order, importing Stopwatch from neon_utils.metrics_utils could cause an import error depending on where Stopwatch was being used

Issues

Other Notes

@NeonDaniel NeonDaniel changed the title Fix circular import in metrics_utils.py Fix extra metrics utils import Nov 10, 2023
@NeonDaniel NeonDaniel merged commit a317071 into dev Nov 10, 2023
11 checks passed
@NeonDaniel NeonDaniel deleted the FIX_MetricsCircularImport branch November 10, 2023 03:03
@github-actions github-actions bot mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NeonDaniel