[FEAT] Async Consumer-based Klatchat Observer #109
Conversation
| @@ -7,7 +7,7 @@ httpx==0.27.0 # required by FastAPI | |||
| Jinja2==3.1.3 | |||
| jsbeautifier==1.15.1 | |||
| kubernetes==29.0.0 | |||
| neon-mq-connector~=0.7 | |||
| neon-mq-connector==0.7.2a5 | |||
There was a problem hiding this comment.
~=0.7,>=0.7.2a5 here would allow this to continue pulling newer compatible releases without explicit updates to dependencies
There was a problem hiding this comment.
~=0.7,>=0.7.2a5here would allow this to continue pulling newer compatible releases without explicit updates to dependencies
Yeah, good point, but I think lets keep it strict until there will be next stable release
| @@ -509,9 +511,7 @@ def handle_message(self, data: dict): | |||
| or Recipients.UNRESOLVED | |||
| ) | |||
| handler_method = self.recipient_to_handler_method.get(recipient) | |||
| if not handler_method: | |||
| LOG.warning(f"Failed to get handler message for recipient={recipient}") | |||
There was a problem hiding this comment.
Is this log worth keeping? Without it, I'm not sure there's any way to see in logs if a message was received
There was a problem hiding this comment.
Is this log worth keeping? Without it, I'm not sure there's any way to see in logs if a message was received
It was pointlessly spamming on every single message that occurred in klat, so I believe we can remove it for now, as we did not really use it so far
Description
Updated klat observer service to work based on async consumer threads