Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for proxy_protocol in proxy_hosts and streams #4105

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

snordmann
Copy link

Closes #1114
Related To #1882
Related To #3537
Related To #3618

@snordmann snordmann force-pushed the enable-proxy-procotol-hosts-streams branch 2 times, most recently from fc6a313 to 2916ff3 Compare October 23, 2024 22:01
@snordmann snordmann force-pushed the enable-proxy-procotol-hosts-streams branch from 2916ff3 to 480c772 Compare October 26, 2024 19:50
@nginxproxymanagerci
Copy link

Docker Image for build 4 is available on
DockerHub
as nginxproxymanager/nginx-proxy-manager-dev:pr-4105

Note: ensure you backup your NPM instance before testing this image! Especially if there are database changes
Note: this is a different docker image namespace than the official image

@jc21 jc21 added the requires-verification Waiting for one or more people to confirm the fix label Oct 30, 2024
@snordmann
Copy link
Author

@jc21 What does the requires-verification label mean? Is it that somebody should test this version manually by setting their tag to nginxproxymanager/nginx-proxy-manager-dev:pr-4105?

If so I am currently running this image an tested a few of the functions (both streams and proxy hosts work with and without the proxy procotol. Editing existing proxy_host and streams works (something that does need automated tests, because I only noticed my incomplete implementation when testing manually, not in the cypress tests/CI - but that is for another time).

Anyway, you probably shouldn't rely on my word alone, so maybe somebody else could verify my changes :)

@jc21
Copy link
Member

jc21 commented Dec 16, 2024

You're correct, in the absence of automated tests I do ask the community to verify changes, and I don't expect anyone to write those tests.

Also I need to manually test things myself and it's hard to find enough time to go through all of the PR's but over Xmas I intend to.

@Coolicky
Copy link

Hi @snordmann

Gave it a try pulled the image nginxproxymanager/nginx-proxy-manager-dev:pr-4105

First thing is that i cannot update existing settings. I'm getting the following js popup

Screenshot from 2025-01-14 19-25-00

Also if created from scratch with proxy_protocol, its always offline
image

Otherwise saw no regression in terms of other functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires-verification Waiting for one or more people to confirm the fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for PROXY Protocol
3 participants