feat: new protocol for zk paillier encryption in range with el gamal … #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manel1874
reviewed
Jan 10, 2025
Comment on lines
+23
to
+30
| //! # mod pregenerated { | ||
| //! # use super::*; | ||
| //! # paillier_zk::load_pregenerated_data!( | ||
| //! # verifier_aux: p::Aux, | ||
| //! # prover_decryption_key: fast_paillier::DecryptionKey, | ||
| //! # ); | ||
| //! # } | ||
| //! # fn main() -> Result<(), Box<dyn std::error::Error>> { |
There was a problem hiding this comment.
I don't think these lines are providing any useful info.
manel1874
reviewed
Jan 10, 2025
| //! let shared_state = "some shared state"; | ||
| //! | ||
| //! let mut rng = rand_core::OsRng; | ||
| //! # let mut rng = rand_dev::DevRng::new(); |
There was a problem hiding this comment.
Suggested change
| //! # let mut rng = rand_dev::DevRng::new(); |
Same here
manel1874
reviewed
Jan 10, 2025
Comment on lines
+57
to
+58
| //! let a = Integer::from_rng_pm(&(Integer::ONE << security.l).complete(), &mut rng); | ||
| //! let b = Integer::from_rng_pm(&(Integer::ONE << security.l).complete(), &mut rng); |
There was a problem hiding this comment.
Same discussion as here: I think you should use the curve order instead and the get_invertible.
manel1874
reviewed
Jan 10, 2025
Comment on lines
+289
to
+294
| { | ||
| fail_if_ne( | ||
| InvalidProofReason::EqualityCheck(1), | ||
| &data.ciphertext.gcd_ref(data.key.n()).complete(), | ||
| Integer::ONE, | ||
| )?; |
There was a problem hiding this comment.
What is this condition wrt the paper? Can you add a comment here?
manel1874
reviewed
Jan 10, 2025
Comment on lines
+324
to
+328
| // let s_to_e: Integer = commitment | ||
| // .s | ||
| // .pow_mod_ref(challenge, &aux.rsa_modulo) | ||
| // .ok_or(BadExponent::undefined())? | ||
| // .into(); |
There was a problem hiding this comment.
Suggested change
| // let s_to_e: Integer = commitment | |
| // .s | |
| // .pow_mod_ref(challenge, &aux.rsa_modulo) | |
| // .ok_or(BadExponent::undefined())? | |
| // .into(); |
manel1874
reviewed
Jan 10, 2025
Comment on lines
+474
to
+475
| let a = Integer::from_rng_pm(&(Integer::ONE << security.l).complete(), &mut rng); | ||
| let b = Integer::from_rng_pm(&(Integer::ONE << security.l).complete(), &mut rng); |
There was a problem hiding this comment.
Same as above. Use the curve order instead
manel1874
reviewed
Jan 10, 2025
| let plaintext = (Integer::ONE << (security.l + security.epsilon)).complete() + 1; | ||
| let a = Integer::from_rng_pm(&(Integer::ONE << security.l).complete(), &mut rng); | ||
| let b = Integer::from_rng_pm(&(Integer::ONE << security.l).complete(), &mut rng); | ||
| let r = run_with::<C, D>(&mut rng, security, plaintext, a,b).expect_err("proof should not pass"); |
There was a problem hiding this comment.
Suggested change
| let r = run_with::<C, D>(&mut rng, security, plaintext, a,b).expect_err("proof should not pass"); | |
| let r = run_with::<C, D>(&mut rng, security, plaintext, a, b).expect_err("proof should not pass"); |
manel1874
reviewed
Jan 10, 2025
| let plaintext = Integer::from_rng_pm(&(Integer::ONE << security.l).complete(), &mut rng); | ||
| let a = Integer::from_rng_pm(&(Integer::ONE << security.l).complete(), &mut rng); | ||
| let b = Integer::from_rng_pm(&(Integer::ONE << security.l).complete(), &mut rng); | ||
| run_with::<C, D>(&mut rng, security, plaintext,a, b).expect("proof failed"); |
There was a problem hiding this comment.
Suggested change
| run_with::<C, D>(&mut rng, security, plaintext,a, b).expect("proof failed"); | |
| run_with::<C, D>(&mut rng, security, plaintext, a, b).expect("proof failed"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…commitment