Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coqPackages.Ordinal: init at 0.5.3 #334904

Merged
merged 2 commits into from
Nov 28, 2024
Merged

coqPackages.Ordinal: init at 0.5.3 #334904

merged 2 commits into from
Nov 28, 2024

Conversation

damhiya
Copy link
Contributor

@damhiya damhiya commented Aug 15, 2024

Description of changes

I added myself to the maintainer list, and added coqPackages.Ordinal.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Aug 15, 2024
@damhiya damhiya force-pushed the ordinal branch 4 times, most recently from 6abd0fa to d94c56a Compare August 15, 2024 17:18
@damhiya damhiya mentioned this pull request Aug 15, 2024
Merged
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 15, 2024
@vbgl vbgl added the 6.topic: coq "A formal proof management system" label Aug 20, 2024
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 2.status: merge conflict This PR has merge conflicts with the target branch labels Nov 5, 2024
@FliegendeWurst
Copy link
Member

@ofborg build coqPackages_8_18.Ordinal

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 17, 2024
@FliegendeWurst
Copy link
Member

Please squash the last two commits

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 18, 2024
@vbgl
Copy link
Contributor

vbgl commented Nov 27, 2024

Test: coq-community/coq-nix-toolbox#291

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 27, 2024
@vbgl vbgl merged commit c78d3b8 into NixOS:master Nov 28, 2024
27 checks passed
vbgl added a commit to vbgl/coq-nix-toolbox that referenced this pull request Nov 28, 2024
@vbgl
Update after NixOS/nixpkgs#334904
0845308
@vbgl vbgl added the backport release-24.11 Backport PR automatically label Nov 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Nov 28, 2024
Merged
1 task
vbgl added a commit to coq-community/coq-nix-toolbox that referenced this pull request Nov 28, 2024
@vbgl
Ordinal 0.5.3 (#291)
349d864 
Update after NixOS/nixpkgs#334904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

Assignees
No one assigned
Labels
6.topic: coq "A formal proof management system" 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damhiya @FliegendeWurst @vbgl @wegank