Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coqPackages.coq-elpi: enable override of ocamlPackages.elpi #374505

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Jan 17, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: coq "A formal proof management system" label Jan 17, 2025
proux01 added a commit to proux01/coq-nix-toolbox that referenced this pull request Jan 17, 2025
@nix-owners nix-owners bot requested a review from CohenCyril January 17, 2025 10:23
proux01 added a commit to proux01/coq-nix-toolbox that referenced this pull request Jan 17, 2025
proux01 added a commit to proux01/coq-nix-toolbox that referenced this pull request Jan 17, 2025
@proux01 proux01 marked this pull request as ready for review January 17, 2025 13:41
@proux01
Copy link
Contributor Author

proux01 commented Jan 17, 2025

@vbgl in CI like coq-elpi or hierarchy-builder, we often need to override the version of ocamlPackages.elpi, which we can currently only do for coqPackages.coq-elpi master, this hack enables it

CI "green":

@vbgl vbgl merged commit ab255a6 into NixOS:master Jan 17, 2025
25 of 29 checks passed
@proux01
Copy link
Contributor Author

proux01 commented Jan 17, 2025

Thanks!

@proux01 proux01 deleted the coq-elpi branch January 17, 2025 13:52
proux01 added a commit to proux01/coq-nix-toolbox that referenced this pull request Jan 17, 2025
proux01 added a commit to proux01/hierarchy-builder that referenced this pull request Jan 17, 2025
proux01 added a commit to proux01/coq-elpi that referenced this pull request Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants