languages/scala: Add scala language support #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotAShelf
requested changes
Oct 6, 2024
modules/plugins/languages/scala.nix
Outdated
| inherit (lib.options) mkOption mkEnableOption; | ||
| inherit (lib.nvim.dag) entryAfter; | ||
|
|
||
| mkBinding = binding: "vim.api.nvim_buf_set_keymap(bufnr, 'n', '${binding.value}', '<cmd>lua ${binding.action}<CR>', {noremap=true, silent=true, desc='${binding.description}'})"; |
There was a problem hiding this comment.
Is there a reason we're defining mkBinding here and not using one of the binding functions from lib?
There was a problem hiding this comment.
Might be just ignorance on my part. lsp/config.nix does a similar thing to set buffer local mappings, which is what I looked at.
There was a problem hiding this comment.
I've inlined this into attach_metals_keymaps now
|
BTW this PR also has nvim-metals still pointing to a fork of mine, because with upstream I am getting a build error on generating helptags. I hope to get this merged scalameta/nvim-metals#693 to fix that. |
|
Switched back to scalameta/nvim-metals for the plugin source |
NotAShelf
requested changes
Oct 7, 2024
Adds LSP support for Scala via nvim-metals
|
If you could add a changelog entry, I think I can merge this later today. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scala language support
Description
Adds basic support for Scala via nvim-metals.
This is very bare bones as of yet. It works, but metals can be configured quite extensively and none of those options are exposed via the module here yet.
Type of change
Checklist
Please try to check at least a majority of the checklist before opening your pull request. Exceptions to this will be reviewed on a case by case basis.
nix fmt).