Remove simple-slack-notify and move to using github slack app #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rmccar
changed the title
rmccar
requested review from
adi-unni,
precious-onyenaucheya-ons and
alessioventuriniAND
precious-onyenaucheya-ons
approved these changes
Oct 9, 2023
Just tested it again and I seem to get the updates |
alessioventuriniAND
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
simple-slack-notifyhas been archived, is no longer maintained and is now running on an old version of node. This PR makes the change of removing that and then I will set up thepat-lib-notificationschannel to monitor these workflows using the github slack app.As part of this I have made the decision to split the tests out into separate workflows due to a problem in slack with the naming of the workflow containing a comma. These were separate jobs anyway that didn't rely on each other so makes sense that they are separate anyway.
Part of the fix for this ONSdigital/design-team#9
Once merged update branch protection and reconfigure slack integration
How to review this PR
/github signinif not prompted/github subscribe ONSdigital/design-systemto start monitoring the repo/github subscribe ONSdigital/design-system workflows:{name:"Lighthouse CI accessibility checks", "Publish Design System to npm", "Run visual regression tests", "Run macro and script tests"}to subscribe to the correct workflows.pat-lib-notificationschannel and see that all notifications are replicated./github unsubscribe ONSdigital/design-systemChecklist
This needs to be completed by the person raising the PR.