Selecting an input prefix/suffix should should focus the associated input #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffix-should-show-the-tooltip-and-put-focus-on-the-input-rm
adi-unni
requested review from
rmccar,
precious-onyenaucheya-ons and
alessioventuriniAND
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rmccar
reviewed
Nov 17, 2023
rmccar
approved these changes
Nov 17, 2023
precious-onyenaucheya-ons
approved these changes
Nov 21, 2023
…ffix-should-show-the-tooltip-and-put-focus-on-the-input-rm
…ffix-should-show-the-tooltip-and-put-focus-on-the-input-rm
alessioventuriniAND
approved these changes
Nov 23, 2023
…ffix-should-show-the-tooltip-and-put-focus-on-the-input-rm
adi-unni
deleted the
enhancement/2411/selecting-an-input-prefixsuffix-should-show-the-tooltip-and-put-focus-on-the-input-rm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: #2945
GDS user research found that users often misclicked the icon to the left of an input. As an enhancement, this change changes the focus from the
<abbr>element to the associated input.How to review this PR
Click on the little pound sign (the prefix/suffix) and check that the focus get set to the input.
Checklist
This needs to be completed by the person raising the PR.