Overwrite top css to align active menu buttons #2954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rmccar
requested review from
adi-unni,
precious-onyenaucheya-ons and
alessioventuriniAND
precious-onyenaucheya-ons
approved these changes
Nov 30, 2023
|
When clicking on the search button, it now drops down slightly. |
Good spot, ill sort that |
adi-unni
approved these changes
Nov 30, 2023
rmccar
deleted the
bug/2953/navigation-menu-button-not-aligned-when-active
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: #2953
Overwrites the top css property to set it at 0 when the button is in a header. This is something that is needed to happen in other cases buttons are used to give the impression of clicking a physical button so I have just overwritten it specifically when it is used in this way. This fixes all buttons in headers as they all have this issue.
Also fixed some code formatting in the header component and fixed extra spacing in the header class list.
How to review this PR
example-header-external-with-navigation-and-search,example-header-external-with-service-linksandexample-header-external-with-sub-navigationChecklist
This needs to be completed by the person raising the PR.