Refactor CharCheckLimit test file to new format #3468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Limit param is defined in documentation but is not used in macro file. Do we need to create a new ticket to remove the param? |
SriHV
changed the title
rmccar
reviewed
Jan 9, 2025
Co-authored-by: rmccar <[email protected]>
Co-authored-by: rmccar <[email protected]>
Co-authored-by: rmccar <[email protected]>
rmccar
approved these changes
Jan 10, 2025
admilne
approved these changes
Jan 10, 2025
rmccar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
ONSDESYS-39
Refactored the document list macro.spec file as per the new format.
How to review this PR
Ask yourself....
run this test command to view the test results:
yarn test --testNamePattern="FOR: Macro: Char check limit"Checklist
This needs to be completed by the person raising the PR.