Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ruff linting issue UP006: Use type instead of Type for type annotation #1555

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

VirajP1002
Copy link
Contributor

@VirajP1002 VirajP1002 commented Nov 22, 2024

What is the context of this PR?

Fixes all instances of the ruff linting issue UP007 to use type instead of Type for type annotation. This involved using the builtin type over typing.Type, there was an instance where 'typing.Dict' was used over 'dict' so this was addressed.

How to review

  • Check all instances are Type annotations have been changed to type, imports are as expected and that there are no linting errors.

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

@VirajP1002 VirajP1002 marked this pull request as ready for review November 22, 2024 17:29
@VirajP1002 VirajP1002 requested a review from a team as a code owner January 10, 2025 11:21
@VirajP1002 VirajP1002 merged commit 565a843 into main Jan 13, 2025
19 checks passed
@VirajP1002 VirajP1002 deleted the remove-ruff-exception-UP006 branch January 13, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants