Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AEP addresses and routing #1909

Merged
merged 5 commits into from
Dec 17, 2024
Merged

Conversation

TucksonDev
Copy link
Contributor

@TucksonDev TucksonDev commented Dec 16, 2024

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arbitrum-docs ✅ Ready (Inspect) Visit Preview Dec 17, 2024 4:39am

@cla-bot cla-bot bot added the s label Dec 16, 2024
@@ -95,7 +95,7 @@ To configure the script, you need to specify the following [environment variable
- `ORBIT_CHAIN_ID`: chain id of the Orbit chain
- `ORBIT_CHAIN_RPC`: RPC of the Orbit chain
- `PARENT_CHAIN_ID`: chain id of the parent chain, which shouldn't be an Arbitrum chain
- `PARENT_CHAIN_TARGET_ADDRESS`: address on the parent chain where 10% of the revenue will be sent to. You can find the potential target addresses in the [canonical contracts](#canonical-contracts) section of this document. If the parent chain is not on that list, or if your chain uses a gas token different than the one the router is configured for, contact the Arbitrum Foundation to obtain a specific target address for your chain.
- `PARENT_CHAIN_TARGET_ADDRESS`: address on the parent chain where 10% of the revenue will be sent to. Please, contact the Arbitrum Foundation to obtain the specific target address for your chain. <!-- You can find the potential target addresses in the [canonical contracts](#canonical-contracts) section of this document. If the parent chain is not on that list, or if your chain uses a gas token different than the one the router is configured for, contact the Arbitrum Foundation to obtain a specific target address for your chain. -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `PARENT_CHAIN_TARGET_ADDRESS`: address on the parent chain where 10% of the revenue will be sent to. Please, contact the Arbitrum Foundation to obtain the specific target address for your chain. <!-- You can find the potential target addresses in the [canonical contracts](#canonical-contracts) section of this document. If the parent chain is not on that list, or if your chain uses a gas token different than the one the router is configured for, contact the Arbitrum Foundation to obtain a specific target address for your chain. -->
- `PARENT_CHAIN_TARGET_ADDRESS`: address on the parent chain where 10% of the revenue will be sent to. Please contact the Arbitrum Foundation to obtain the specific target address for your chain. <!-- You can find the potential target addresses in this document's [canonical contracts](#canonical-contracts) section. If the parent chain is not on that list, or if your chain uses a gas token different than the one the router is configured for, contact the Arbitrum Foundation to obtain a specific target address for your chain. -->

Copy link
Contributor

@anegg0 anegg0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits, but LGTM , otherwise :)

@hkalodner hkalodner merged commit 70c0b6a into master Dec 17, 2024
5 checks passed
@hkalodner hkalodner deleted the update-aep-fees-addresses branch December 17, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants