Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSPSDS-472: Improve technical setup #246

Merged
merged 8 commits into from
Nov 9, 2018

Conversation

jasiekmiko
Copy link
Contributor

The code changes comprise:

web/config/routes.rb Outdated Show resolved Hide resolved
@broder broder changed the title Mspsds 472 improve technical setup MSPSDS-472: Improve technical setup Nov 8, 2018
# This is the page that will show for timeouts, currently showing the same as an internal error
match "/503", to: "errors#internal_server_error", via: :all

mount PgHero::Engine, at: "pghero"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this in production? Also, do we need to be running https://github.com/ankane/pghero/blob/master/guides/Rails.md#historical-query-stats?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we very much do - otherwise we can't properly evaluate the performance.
And that was one of my comments, do
https://github.com/ankane/pghero/blob/master/guides/Rails.md#historical-query-stats and
https://github.com/ankane/pghero/blob/master/guides/Rails.md#historical-space-stats
seem useful here?
I'm tempted to say yes, but also not sure what we'd want to use for the stats capture scheduling. I've had quick look at https://github.com/ondrejbartas/sidekiq-cron, am i barking up the right tree here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, there's a recommendation to use a separate user for phHero, but the required approach seems super messy:
https://github.com/ankane/pghero/blob/master/guides/Permissions.md

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sidekiq-cron sounds like it might work!

@coveralls
Copy link

coveralls commented Nov 8, 2018

Pull Request Test Coverage Report for Build 1155

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 94.308%

Totals Coverage Status
Change from base Build 1150: 0.02%
Covered Lines: 2336
Relevant Lines: 2477

💛 - Coveralls

@jasiekmiko
Copy link
Contributor Author

Damn it, I've written a whole host of comments before putting into review that I've accidentally deleted now :P

web/config/database.yml Outdated Show resolved Hide resolved
@jasiekmiko
Copy link
Contributor Author

@broder as discussed, I'll want to push this through and leave enabling pghero historical stats to a separate PR

@jasiekmiko jasiekmiko force-pushed the MSPSDS-472-ImproveTechnicalSetup branch from f525166 to 1a64446 Compare November 9, 2018 13:35
Copy link
Contributor

@broder broder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants