Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for german + french translation #114

Merged
merged 2 commits into from
Nov 15, 2023
Merged

PR for german + french translation #114

merged 2 commits into from
Nov 15, 2023

Conversation

ChristophCaina
Copy link
Contributor

This PR contains german and french translation json files.

add german translation
#55
Thanks to @Henry-Sir for providing a translated file
add french translation
#81
thanks to @JulienNabaztag for providing the translation
This was referenced Nov 15, 2023
@Olen
Copy link
Owner

Olen commented Nov 15, 2023

I just speak a minimum amount of german, and no french, but it does not look like it contains any profanities, as far as I can tell...

@Olen Olen merged commit d66fe62 into Olen:master Nov 15, 2023
3 checks passed
@ChristophCaina
Copy link
Contributor Author

unfortunately, I also don't speak french.
And tbh: My expectation was: if someone has already made the effort to share a complete json file within the issues here, I would not expect that it contains any profanities.

The german translation looked good so far - and since I've already started with one, I took the chance to implement the provided ones.
Confirmed: there are no profanities at least, within the german translation.

Thanks for the merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants