Feature: Edit existing chart #297
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
grodin
commented
Feb 13, 2024
grodin
commented
- refactor: Reduce visiblity of ChartsWorkflowState
- refactor: Hide state in AddNewChartsWorkflow
- feat: Add workflow to display chart details
- test: Add failing test for saving edited chart
- feat(firebase): Implement saveEditedChart()
grodin
force-pushed
the
feat/edit-existing-chart
branch
from
f3f3ee8 to
91c838d
Compare
grodin
force-pushed
the
feat/edit-existing-chart
branch
2 times, most recently
from
101fdf0 to
fba22a7
Compare
The workflow doesn't yet allow editing.
grodin
force-pushed
the
feat/edit-existing-chart
branch
from
fba22a7 to
adb440d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.