Merge pull request #194 from OnroerendErfgoed/feature/184_system_fiel…

…ds_optional_status Feature/184 system fields optional status
OnroerendErfgoed · Jan 11, 2024 · 48af99b · 48af99b
2 parents 9631dcb + 1ee9a1e
commit 48af99b
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 16 deletions.
diff --git a/src/__tests__/SystemFields.cy.ts b/src/__tests__/SystemFields.cy.ts
@@ -18,9 +18,9 @@ describe('SystemFields - no data', () => {
     mount(TestComponent);
   });
 
-  it('has an empty status field', () => {
+  it('hides the status field when empty', () => {
     mount(TestComponent);
-    cy.dataCy('systemfield-status').should('have.text', 'Status: -');
+    cy.dataCy('systemfield-status').should('not.exist');
   });
 
   it('has an empty aangemaakt door field', () => {

diff --git a/src/components/dumb/SystemFields.vue b/src/components/dumb/SystemFields.vue
@@ -1,6 +1,6 @@
 <template>
   <ul data-cy="systemfield-ul">
-    <li data-cy="systemfield-status"><span>Status:</span> {{ props.status || '-' }}</li>
+    <li v-if="props.status" data-cy="systemfield-status">Status: {{ props.status }}</li>
     <li data-cy="systemfield-aangemaakt-door">
       <span>Aangemaakt door:</span> {{ props.createdBy || '-' }} op {{ createdAt }}
     </li>

diff --git a/src/models/system-fields.ts b/src/models/system-fields.ts
@@ -1,5 +1,5 @@
 export interface ISystemFieldsProps {
-  status: string;
+  status?: string;
   createdBy: string;
   createdAt: string;
   updatedBy: string;

diff --git a/src/stories/dumb-components/system-fields.stories.ts b/src/stories/dumb-components/system-fields.stories.ts
@@ -19,23 +19,12 @@ const meta: Meta<typeof SystemFields> = {
     updatedBy: 'Miss. Foo',
     updatedAt: '2023-05-24T13:45:03.497579+02:00',
   },
-  render: (args) => ({
-    setup() {
-      return { args };
-    },
-    template: `<SystemFields></SystemFields>`,
-  }),
 };
 
 export default meta;
 type Story = StoryObj<typeof SystemFields>;
 
-export const Default: Story = {
-  render: () => ({
-    components: { SystemFields },
-    template: `<SystemFields></SystemFields>`,
-  }),
-};
+export const Default: Story = {};
 
 export const Slot: Story = {
   render: (args) => ({