forked from AmazingAmpharos/OoT-Randomizer
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stick/Nut Upgrade Model Improvements #2313
Open
rrealmuto
wants to merge
3
commits into
OoTRandomizer:Dev
Choose a base branch
from
rrealmuto:smoke
base: Dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenhl
added
Type: Enhancement
New feature or request
Component: ASM/C
Changes some internals of the ASM/C libraries
Status: Needs Review
Someone should be looking at it
Status: Under Consideration
Developers are considering whether to accept or decline the feature described
labels
Oct 1, 2024
It would be nice to have a same effect for magic meter maybe ? |
GSKirox
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of formatting nitpicks
Co-authored-by: GSKirox <[email protected]>
Co-authored-by: GSKirox <[email protected]>
GSKirox
approved these changes
Jan 6, 2025
cjohnson57
removed
the
Status: Under Consideration
Developers are considering whether to accept or decline the feature described
label
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: ASM/C
Changes some internals of the ASM/C libraries
Type: Enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a flame/smoke effect to the stick/nut upgrade GI models as shown below.