Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New SFX cosmetic : Rupee change #2327

Open
wants to merge 1 commit into
base: Dev
Choose a base branch
from

Conversation

GSKirox
Copy link
Collaborator

@GSKirox GSKirox commented Nov 8, 2024

Shoutouts to Maple for the great video reference with all sounds tested :
https://youtu.be/2rYXG7XyYZE?si=maMx9DHe_fYEGeia

The Ear-Safe choice is using a new Painful Rupee tag different from the already existing Painful one, since it was not really accurate for sounds that play every frame as shown by the video.

@fenhl fenhl added Type: Enhancement New feature or request Status: Needs Review Someone should be looking at it Status: Needs Testing Probably should be tested Status: Under Consideration Developers are considering whether to accept or decline the feature described Component: Cosmetics Affects the patching of cosmetics labels Nov 8, 2024
@cjohnson57 cjohnson57 removed the Status: Under Consideration Developers are considering whether to accept or decline the feature described label Jan 13, 2025
@cjohnson57 cjohnson57 self-assigned this Jan 13, 2025
@cjohnson57
Copy link
Collaborator

Getting this error when I choose random ear-safe (for any setting, not just this one)
image

SoundHooks
Traceback (most recent call last):
  File "C:\Users\Caleb\Repos\OoT-Randomizer-Tests\OoTRandomizer.py", line 57, in start
    main(settings)
  File "C:\Users\Caleb\Repos\OoT-Randomizer-Tests\Main.py", line 57, in main
    patch_and_output(settings, spoiler, rom)
  File "C:\Users\Caleb\Repos\OoT-Randomizer-Tests\Main.py", line 327, in patch_and_output
    patch_cosmetics_log = prepare_rom(spoiler, world, rom, settings, rng_state, restore_rom)
  File "C:\Users\Caleb\Repos\OoT-Randomizer-Tests\Main.py", line 208, in prepare_rom
    cosmetics_log = patch_cosmetics(settings, rom)
  File "C:\Users\Caleb\Repos\OoT-Randomizer-Tests\Cosmetics.py", line 1265, in patch_cosmetics
    patch_func(rom, settings, log, cosmetic_context_symbols)
  File "C:\Users\Caleb\Repos\OoT-Randomizer-Tests\Cosmetics.py", line 790, in patch_sfx
    selection = random.choice(Sounds.get_hook_pool(hook, True)).value.keyword
  File "C:\Users\Caleb\Repos\OoT-Randomizer-Tests\Sounds.py", line 236, in get_hook_pool
    if sound_hook is Sounds.SoundHooks.RUPEE:
  File "C:\Users\Caleb\AppData\Local\Programs\Python\Python310\Lib\enum.py", line 437, in __getattr__
    raise AttributeError(name) from None
AttributeError: SoundHooks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cosmetics Affects the patching of cosmetics Status: Needs Review Someone should be looking at it Status: Needs Testing Probably should be tested Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants