fix(tp/etp): remove some of the immediate updates to allow aborts to …

…come through first
Open-Agriculture · Jan 6, 2024 · 82d8e23 · 82d8e23
1 parent 7687bea
commit 82d8e23
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/isobus/src/can_extended_transport_protocol.cpp b/isobus/src/can_extended_transport_protocol.cpp
@@ -208,7 +208,6 @@ namespace isobus
 				if (0 != packetsToBeSent)
 				{
 					session->set_state(StateMachineState::SendDataPacketOffset);
-					update_state_machine(session);
 				}
 			}
 		}
@@ -686,7 +685,6 @@ namespace isobus
 				if (send_data_packet_offset(session))
 				{
 					session->set_state(StateMachineState::SendDataTransferPackets);
-					update_state_machine(session); // Immediately update the state machine to send the next message
 				}
 			}
 			break;

diff --git a/isobus/src/can_transport_protocol.cpp b/isobus/src/can_transport_protocol.cpp
@@ -263,7 +263,7 @@ namespace isobus
 			else if (StateMachineState::WaitForClearToSend != session->state)
 			{
 				// The session exists, but we're not in the right state to receive a CTS, so we must abort
-				CANStackLogger::warn("[TP]: Received a Clear To Send (CTS) message for 0x%05X, but not expecting one, aborting session->", parameterGroupNumber);
+				CANStackLogger::warn("[TP]: Received a Clear To Send (CTS) message for 0x%05X, but not expecting one, aborting session.", parameterGroupNumber);
 				abort_session(session, ConnectionAbortReason::ClearToSendReceivedWhileTransferInProgress);
 			}
 			else
@@ -276,7 +276,6 @@ namespace isobus
 				if (0 != packetsToBeSent)
 				{
 					session->set_state(StateMachineState::SendDataTransferPackets);
-					update_state_machine(session);
 				}
 			}
 		}