[VT]: Use internal protocol callbacks for pool upload, standardize lo…

…gging calls

isobus/include/can_general_parameter_group_numbers.hpp

@@ -13,21 +13,20 @@
 namespace isobus
 {
 
-    enum class CANLibParameterGroupNumber
-    {
+	enum class CANLibParameterGroupNumber
+	{
 		Any = 0x0000,
-        WorkingSetMaster = 0xFE0D,
-        VirtualTerminalToECU = 0xE600,
+		WorkingSetMaster = 0xFE0D,
+		VirtualTerminalToECU = 0xE600,
 		ECUtoVirtualTerminal = 0xE700,
-        Acknowledge = 0xE800,
-        ParameterGroupNumberRequest = 0xEA00,
-        TransportProtocolData = 0xEB00,
-        TransportProtocolCommand = 0xEC00,
-        AddressClaim = 0xEE00,
-        ProprietaryA = 0xEF00
-    };
+		Acknowledge = 0xE800,
+		ParameterGroupNumberRequest = 0xEA00,
+		TransportProtocolData = 0xEB00,
+		TransportProtocolCommand = 0xEC00,
+		AddressClaim = 0xEE00,
+		ProprietaryA = 0xEF00
+	};
 
 } // namespace isobus
 
 #endif // CAN_GENERAL_PARAMETER_GROUP_NUMBERS_HPP
-

isobus/include/isobus_virtual_terminal_client.hpp

@@ -9,13 +9,13 @@
 #ifndef ISOBUS_VIRTUAL_TERMINAL_CLIENT_HPP
 #define ISOBUS_VIRTUAL_TERMINAL_CLIENT_HPP
 
-#include "can_partnered_control_function.hpp"
 #include "can_internal_control_function.hpp"
+#include "can_partnered_control_function.hpp"
 #include "processing_flags.hpp"
 
 #include <memory>
-#include <vector>
 #include <thread>
+#include <vector>
 
 namespace isobus
 {
@@ -319,7 +319,7 @@ namespace isobus
 
 		// These are the functions for specifying your pool to upload.
 		// You have a few options:
-		// 1. Upload in one blob of contigious memory 
+		// 1. Upload in one blob of contigious memory
 		// This is good for small pools or pools where you have all the data in memory.
 		// 2. Get a callback at some inteval to provide data in chunks
 		// This is probably better for huge pools if you are RAM constrained, or if your
@@ -501,6 +501,11 @@ namespace isobus
 		                             ControlFunction *destinationControlFunction,
 		                             bool successful,
 		                             void *parentPointer);
+		static bool process_internal_object_pool_upload_callback(std::uint32_t callbackIndex,
+		                                                         std::uint32_t bytesOffset,
+		                                                         std::uint32_t numberOfBytesNeeded,
+		                                                         std::uint8_t *chunkBuffer,
+		                                                         void *parentPointer);
 
 		void worker_thread_function();