Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples]: Add NMEA2000 generator/parser #339

Merged
merged 3 commits into from
Oct 28, 2023

Conversation

GwnDaan
Copy link
Member

@GwnDaan GwnDaan commented Oct 27, 2023

Added generator and parser example programs to test the libraries NMEA2000 message interface functionality. Note that the output of the parser is not that neat, so you'd probably want to disable some of the listeners to be able to read your console properly...

Also fixed a few small incorrect units applied, basically sometimes 10E... where it should've been 1E... to get the correct output/input

@GwnDaan GwnDaan requested a review from ad3154 October 27, 2023 22:39
@GwnDaan GwnDaan self-assigned this Oct 27, 2023
@GwnDaan GwnDaan temporarily deployed to Integrate Pull Request October 27, 2023 22:39 — with GitHub Actions Inactive
@ad3154 ad3154 force-pushed the nmea2000-messages branch from fa5e62d to 61ea638 Compare October 28, 2023 00:35
@ad3154 ad3154 force-pushed the daan/nmea2000-messages branch from b30d785 to 7d63750 Compare October 28, 2023 00:37
@ad3154 ad3154 force-pushed the daan/nmea2000-messages branch from 9e2ce00 to 88370b7 Compare October 28, 2023 00:46
cmake_minimum_required(VERSION 3.16)
project(fast_packet_protocol_example)

set(CMAKE_CXX_STANDARD 14)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, I opened #340 because apparently there are nicer or at least more modern ways to do this 🙂

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

68.0% 68.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Member

@ad3154 ad3154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge thanks for an excellent review and testing this for me - I really appreciate it!!!

@ad3154 ad3154 merged commit 23bb9cf into nmea2000-messages Oct 28, 2023
6 of 7 checks passed
@ad3154 ad3154 deleted the daan/nmea2000-messages branch October 28, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants