-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VT] Wait on response before processing next command #380
Conversation
1076417
to
3334b5a
Compare
9abf633
to
c156d64
Compare
The main branch is currently failing to build on PlatformIO: https://github.com/Open-Agriculture/AgIsoStack-plus-plus/actions/runs/7147251833/job/19466433156. This PR will also fix that |
Tested this by re-basing the seeder example on your branch, and... it's a little slow, only around 20 messages per second. Our update rate of the interface means that after a response is received we have to wait a fair bit before sending the next message which causes some noticeable lag. I am wondering if we should explore options to send the next message on-response. Some ideas:
AgISOVirtualTerminal.2023-12-10.09-31-43.mp4 |
c156d64
to
156843c
Compare
I opted for the mutex because I feel like it's the most efficient one, good that you tested this. I didn't have the environment to notice it |
156843c
to
1d2c3a7
Compare
1d2c3a7
to
d9f64ee
Compare
Quality Gate failedFailed conditions 64.6% Coverage on New Code (required ≥ 80%) |
To comply with the standard, we must wait for responses from the VT server before sending the next command. This PR implements that behaviour