Bring back required C++ standard to 11 (from 14) #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GwnDaan
force-pushed
the
daan/better-cpp-standard-checking
branch
2 times, most recently
from
f521660 to
92d30b0
Compare
This is a known issue in C++11, it is fixed in C++14 and later
GwnDaan
force-pushed
the
daan/better-cpp-standard-checking
branch
from
1405176 to
3e8a593
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ad3154
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides setting C++14 back to C++11 as the required minimum standard, I changed the way we check required version, this should resolve #357 as well.
I had to make some changes in the unit-testing, because we used some C++14 specific features there, and I feel like it's best to be completely uniform of the usage of C++ standards. Hence no C++14 features in unit-testing either.