Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VT]: Add handling of unsupported VT function #404

Merged
merged 1 commit into from
Jan 21, 2024
Merged

[VT]: Add handling of unsupported VT function #404

merged 1 commit into from
Jan 21, 2024

Conversation

GwnDaan
Copy link
Member

@GwnDaan GwnDaan commented Jan 20, 2024

Closes #377

@GwnDaan GwnDaan added enhancement New feature or request iso: virtual terminal Related to the ISO-11783:7 standard labels Jan 20, 2024
@GwnDaan GwnDaan requested a review from ad3154 January 20, 2024 08:52
@GwnDaan GwnDaan self-assigned this Jan 20, 2024
@GwnDaan GwnDaan changed the title feat(vt): add handling of unsupported VT function [VT]: Add handling of unsupported VT function Jan 20, 2024
@GwnDaan GwnDaan force-pushed the daan/add-unsupported-vt-functions branch from 8faa740 to 119c4d8 Compare January 20, 2024 14:44
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
14.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ad3154
Copy link
Member

ad3154 commented Jan 20, 2024

Do you think it would be valuable to also have a way to get a list if all previously cached unsupported functions? Or not really?

@GwnDaan
Copy link
Member Author

GwnDaan commented Jan 20, 2024 •
edited
Loading

Do you think it would be valuable to also have a way to get a list if all previously cached unsupported functions?

Hmm, I'm not sure. What do you think it can be used for? You currently only know that a function is unsupported after you tried to send it, so we can't really use that list at startup or something I think

@ad3154
Copy link
Member

ad3154 commented Jan 20, 2024

Hmm, I'm not sure. What do you think it can be used for? You currently only know that a function is unsupported after you tried to send it, so we can't really use that list at startup or something I think

Maybe unit tests? Haha. I'm not sure, it was just a thought, but I think that doing something on the client side based on some known list of unsupported functions could be challenging, so maybe it's not particularly helpful

@GwnDaan GwnDaan merged commit 2c4bc66 into main Jan 21, 2024
10 checks passed
@GwnDaan GwnDaan deleted the daan/add-unsupported-vt-functions branch January 21, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ad3154 ad3154 ad3154 approved these changes

Assignees

@GwnDaan GwnDaan

Labels
enhancement New feature or request iso: virtual terminal Related to the ISO-11783:7 standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add (VT) Unsupported VT Function message
2 participants
@GwnDaan @ad3154