Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core]: Add a reference for ISO and SAE preferred addresses #412

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

ad3154
Copy link
Member

@ad3154 ad3154 commented Jan 24, 2024

Describe your changes

This was inspired by a comment on #407 and adds a reference for standard preferred control function addresses. This can be used as a reference for developers looking to assign a control function's preferred SA if they use a "well-known" standard function code.

As usual, users should not expect that the preferred address will be used if their NAME fails to arbitrate against another NAME on the bus that also wants that address. In those cases the stack will automatically select an appropriate address in the self configurable range if the NAME allows arbitrary address capabilities.

How has this been tested?

This information was directly sourced from the publically available ISO11783-11 database here. Since the change is header-only, no tests were required.

@ad3154 ad3154 added enhancement New feature or request iso: data link Related to the ISO-11783:3 standard labels Jan 24, 2024
@ad3154 ad3154 requested a review from GwnDaan January 24, 2024 01:51
@ad3154 ad3154 self-assigned this Jan 24, 2024
@ad3154 ad3154 force-pushed the preferred-addresses branch from 3cf8211 to 091cae6 Compare January 25, 2024 00:54
Added a reference for standard preferred control function addresses.
@ad3154 ad3154 force-pushed the preferred-addresses branch from 091cae6 to d8cea33 Compare January 25, 2024 01:05
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ad3154 ad3154 requested a review from GwnDaan January 25, 2024 19:03
@ad3154 ad3154 merged commit eaa92e5 into main Jan 25, 2024
10 checks passed
@ad3154 ad3154 deleted the preferred-addresses branch January 25, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iso: data link Related to the ISO-11783:3 standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants