[Core]: Require complete message representation at construction time

[GwnDaan]

Describe your changes

This should make it a bit more self-explanatory what the message needs to be functional, instead of needing to know which loosely-required functions you have to call before you get a functional message. Also did a few cleanups of the CANNetworkManager where older things were still present or unclear

How has this been tested?

Ran the virtual terminal examples to ensure core communication is still correct

[ad3154]

Seems OK, probably makes sense to require these values up front anyways. Sonar's complaint about new we should maybe look at if/when we refactor fast packet protocol.

[sonarqubecloud]

Quality Gate failed

Failed conditions

E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[ad3154]

One note... removing receive_can_message(const CANMessage &message); made it impossible to receive long messages in the unit tests without actually sending all the transport messages I think, which is kind of unfortunate. I had a unit test in the TC server for receiving the entire DDOP but now have to leave it out I think.

[GwnDaan]

removing receive_can_message(const CANMessage &message); made it impossible to receive long messages in the unit tests without actually sending all the transport messages I think, which is kind of unfortunate. I had a unit test in the TC server for receiving the entire DDOP but now have to leave it out I think.

@ad3154, sorry for that. I think it's better to try to test the TC server without involving the NetworkManager all together, like I managed to do with the (extended) transport protocol tests. Although that would require making some callback for sending/receiving messages, exactly the problem you're facing right now.

Another much more simpler option is to just wrap the receive function of the TC server for testing, like you did with the VT client here:

AgIsoStack-plus-plus/test/vt_client_tests.cpp

Lines 21 to 24 in 0192b52

	void test_wrapper_process_rx_message(const CANMessage &message, void *parentPointer)
	{
	VirtualTerminalClient::process_rx_message(message, parentPointer);
	}