[TC]: Add product abstraction to DDOP helper #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a way to get rate/product information from a DDOP.
ad3154
force-pushed
the
adrian/ddop-helpers
branch
from
ee79ec9 to
c8fb876
Compare
|
GwnDaan
approved these changes
Mar 3, 2024
|
Hmmmmm... the more I think about it, the more I think some of these things need their parent element number included in the returned data, that way the TC knows what element to use when commanding or requesting the value without needing to search the whole DDOP again. I will merge this, but I think I will follow up with another PR that expands the data returned Edit: Added in f7d1a87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This provides a way to get rate/product information from a DDOP. Generally it considers any
Binto be the root of a product, which seems to be fairly standard.This is intended to be used in a TC server to quickly learn about what products the implement might have.
The information provided includes data about:
How has this been tested?
Expanded TC server unit tests to include parsing for product information.